jmarantz commented on a change in pull request #1998:
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1998#discussion_r459416906
##########
File path: net/instaweb/rewriter/process_context.cc
##########
@@ -58,7 +58,7 @@ ProcessContext::ProcessContext()
// url/url_util.cc lazily initializes its "standard_schemes" table in a
// thread-unsafe way and so it must be explicitly initialized prior to thread
// creation, and explicitly terminated after thread quiescence.
- url::Initialize();
+ //url::Initialize();
Review comment:
Reading the comment I left above about thread-unsafe; is it worth
checking whether the latest version self-initializes in a thread-safe way?
The other thing I'm wondering about is between unit tests, does it leave
threads running that might make things less deterministic. But if we can get
tests to pass then I think it's worth committing, and we can always figure out
how to revisit if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
