jmarantz commented on a change in pull request #1998:
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1998#discussion_r459383523
##########
File path: net/instaweb/rewriter/dedup_inlined_images_filter_test.cc
##########
@@ -39,10 +39,10 @@ namespace net_instaweb {
namespace {
// Filenames of resource files.
-const char kCuppaPngFilename[] = "Cuppa.png";
-const char kPuzzleJpgFilename[] = "Puzzle.jpg";
+constexpr absl::string_view kCuppaPngFilename = "Cuppa.png";
Review comment:
At least in this case, kCuppaPngFilename is not used as a format string;
it's just used in StrCat.
If we do use a statically initialized string constant, would it work to
declare that as
```
constexpr char kFoo[] = "foo";
```
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
