[
https://issues.apache.org/jira/browse/PARQUET-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479593#comment-16479593
]
ASF GitHub Bot commented on PARQUET-979:
----------------------------------------
majetideepak commented on a change in pull request #465: PARQUET-979: Limit
size of min, max or disable stats for long binary types
URL: https://github.com/apache/parquet-cpp/pull/465#discussion_r189076178
##########
File path: src/parquet/column_writer.cc
##########
@@ -33,6 +33,8 @@
namespace parquet {
+static constexpr int MAX_STATS_SIZE = 4096; // limit stats to 4k
Review comment:
I followed parquet-mr.
https://github.com/apache/parquet-mr/blob/0d55abd05b0e5027c18e60d1ac3b22998dd00951/parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java#L88
I don't see this specified in the spec. We should probably add it there. I
will open a JIRA to do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Limit size of min, max or disable stats for long binary types
> -------------------------------------------------------------------
>
> Key: PARQUET-979
> URL: https://issues.apache.org/jira/browse/PARQUET-979
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
> Priority: Major
> Fix For: cpp-1.4.0
>
>
> Other Parquet implementations like parquet-mr disable min/max values for long
> binary types > 4KB. For known logical types comparisons, we could approximate
> min/max values. We need to implement this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
