[ 
https://issues.apache.org/jira/browse/PARQUET-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479596#comment-16479596
 ] 

ASF GitHub Bot commented on PARQUET-979:
----------------------------------------

xhochy commented on a change in pull request #465: PARQUET-979: Limit size of 
min, max or disable stats for long binary types
URL: https://github.com/apache/parquet-cpp/pull/465#discussion_r189076583
 
 

 ##########
 File path: src/parquet/column_writer.cc
 ##########
 @@ -33,6 +33,8 @@
 
 namespace parquet {
 
+static constexpr int MAX_STATS_SIZE = 4096;  // limit stats to 4k
 
 Review comment:
   The alternative would be to use this as sensible default and add it as an 
option to `WriterProperties`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [C++] Limit size of min, max or disable stats for long binary types
> -------------------------------------------------------------------
>
>                 Key: PARQUET-979
>                 URL: https://issues.apache.org/jira/browse/PARQUET-979
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cpp
>            Reporter: Deepak Majeti
>            Assignee: Deepak Majeti
>            Priority: Major
>             Fix For: cpp-1.4.0
>
>
> Other Parquet implementations like parquet-mr disable min/max values for long 
> binary types > 4KB. For known logical types comparisons, we could approximate 
> min/max values. We need to implement this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to