[jira] [Commented] (PARQUET-979) [C++] Limit size of min, max or disable stats for long binary types

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/PARQUET-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479682#comment-16479682
 ] 

ASF GitHub Bot commented on PARQUET-979:
----------------------------------------

xhochy commented on a change in pull request #465: PARQUET-979: Limit size of 
min, max or disable stats for long binary types
URL: https://github.com/apache/parquet-cpp/pull/465#discussion_r189094301
 
 

 ##########
 File path: src/parquet/properties.h
 ##########
 @@ -348,19 +357,23 @@ class PARQUET_EXPORT WriterProperties {
   }
 
   Encoding::type encoding(const std::shared_ptr<schema::ColumnPath>& path) 
const {
-    return column_properties(path).encoding;
+    return column_properties(path).encoding_;
   }
 
   Compression::type compression(const std::shared_ptr<schema::ColumnPath>& 
path) const {
-    return column_properties(path).codec;
+    return column_properties(path).codec_;
   }
 
   bool dictionary_enabled(const std::shared_ptr<schema::ColumnPath>& path) 
const {
-    return column_properties(path).dictionary_enabled;
+    return column_properties(path).dictionary_enabled_;
   }
 
   bool statistics_enabled(const std::shared_ptr<schema::ColumnPath>& path) 
const {
-    return column_properties(path).statistics_enabled;
+    return column_properties(path).statistics_enabled_;
+  }
+
+  size_t max_stats_size(const std::shared_ptr<schema::ColumnPath>& path) const 
{
 
 Review comment:
   Please use `max_statistics_size`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [C++] Limit size of min, max or disable stats for long binary types
> -------------------------------------------------------------------
>
>                 Key: PARQUET-979
>                 URL: https://issues.apache.org/jira/browse/PARQUET-979
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cpp
>            Reporter: Deepak Majeti
>            Assignee: Deepak Majeti
>            Priority: Major
>             Fix For: cpp-1.4.0
>
>
> Other Parquet implementations like parquet-mr disable min/max values for long 
> binary types > 4KB. For known logical types comparisons, we could approximate 
> min/max values. We need to implement this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)