[ 
https://issues.apache.org/jira/browse/PDFBOX-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116526#comment-14116526
 ] 

Tilman Hausherr edited comment on PDFBOX-1094 at 8/30/14 7:09 PM:
------------------------------------------------------------------

Here's whats new:
- the substream matrix is combined with the pattern matrix
- ignore 32767 steps. I previously tried a more meaningful solution, i.e. to 
compare it to the page size, but that does not always work. I found these in 
several digitalcorpora files, it is just crap.
- new in TilingPaint besides xform: the translation is adjusted not according 
to the full rectangle, but according to the BBox. (The BBox is smaller or equal 
than the steps)
The PDF spec is not always helpful. It was probably written after the coding, 
and is more like a summary of what was done. One has to try different 
approaches and see what tests work.

So whats better now:
- PDFBOX-1442 works for the first time
- PDFBOX-2098-asyTUG.pdf page 6 works for the first time
- PDFBOX-1094-094730.pdf page 3 works for the first time
- PATTYP1 has improved (but not perfect, see comment elsewhere)
- everything that already worked is no longer "blocky".

What's not solved:
- survey.pdf, the scrollbars. I'll research this later. I believe this worked 
in February with the solution of Andreas or mine at that time.
- PATTYP1 only partially solved, see PDFBOX-2217, see also the 2008 comment by 
Ken Sharp here
http://bugs.ghostscript.com/show_bug.cgi?id=687196
(The ghostscript folks are great, and they've done a lot for PDFBox without 
knowing it, by making it possible to build PS test files)
- PATTYP2, there is a triangle on the top right
- PDFBOX-1958-cinnebar.pdf

Sure, I would have preferred to get all 100% right. But considering that I 
improved many renderings, I'm probably not totally off.


was (Author: tilman):
Here's whats new:
- the substream matrix is combined with the pattern matrix
- ignore 32767 steps. I previously tried a more meaningful solution, i.e. to 
compare it to the page size, but that does not always work. I found these in 
several digitalcorpora files, it is just crap.
- new in TilingPaint besides xform: the translation is adjusted not according 
to the full rectangle, but according to the BBox. (The BBox is smaller or equal 
than the steps)
The PDF spec is not always helpful. It was probably written after the coding, 
and is more like a summary of what was done. One has to try different 
approaches and see what tests work.

So whats better now:
- PDFBOX-1442 works for the first time
- PDFBOX-2098-asyTUG.pdf page 6 works for the first time
- PDFBOX-1094-094730.pdf page 3 works for the first time
- PATTYP1 has improved (but not perfect, see comment elsewhere)
- everything that already worked is no longer "blocky".

What's not solved:
- survey.pdf, the scrollbars. I'll research this
- PATTYP1, see PDFBOX-2217, see also the 2008 comment by Ken Sharp here
http://bugs.ghostscript.com/show_bug.cgi?id=687196
(The ghostscript folks are great, and they've done a lot for PDFBox without 
knowing it, by making it possible to build PS test files)
- PATTYP2, there is a triangle on the top right
- PDFBOX-1958-cinnebar.pdf

Sure, I would have preferred to get all 100% right. But considering that I 
improved many renderings, I'm probably not totally off.

> Pattern colorspace support
> --------------------------
>
>                 Key: PDFBOX-1094
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1094
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Rendering
>    Affects Versions: 1.6.0
>            Reporter: Andreas Lehmkühler
>            Priority: Minor
>         Attachments: ColoredTilingPaint.patch, PATTYP1.pdf, PATTYP2.pdf, 
> PDF32000_2008_pg737.pdf, PDFBOX-1094-065514-XStep32767.pdf, 
> PDFBOX-1094-094730.pdf, PDFBOX-1094-096213-p18.pdf, 
> PDFBOX-1861-tracemonkey13.png, PDFStreamEngine.patch, PageDrawer.patch, 
> _pdfbox-1094-tiling_pattern.pdf-1-blurry.png, gs-bugzilla693653.pdf, 
> jagpdf_doc_patterns.pdf, jagpdf_doc_patterns.pdf-1.png, 
> pdfbox-1094-pdf32000_2008_pg737.pdf-1.png, 
> pdfbox-1094-pdf32000_2008_pg737.pdf-1.png, 
> pdfbox-1094-tiling_pattern.pdf-1.png, pdfbox-1094-tiling_pattern.pdf-1.png, 
> pdfbox-1094-tiling_pattern.pdf-1.png, pdfbox-1861-tracemonkey.pdf-13.png, 
> pdfbox-1861-tracemonkey.pdf-13.png, tiling_pattern.pdf
>
>
> PDFBox doesn't support PDPattern colorspaces



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to