[
https://issues.apache.org/jira/browse/PDFBOX-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116565#comment-14116565
]
Tilman Hausherr edited comment on PDFBOX-1094 at 8/30/14 9:23 PM:
------------------------------------------------------------------
I always understood your comment the way you meant it in the first place. I
never tried (1), mostly because... I didn't understand it. What I did is (2)
(use the xform), plus your comment from March (use the substream start matrix)
because this worked with the PDFBOX-1442 shading patterns, and my small own
improvement to use the correct translation source (BBox lower left instead of
full rectangle lower left). What I mean is that except for the xform part, I
implemented your sugestion (from March).
I know there's room for improvement, see my previous comment. It is somewhat
suspicious that in my PDPattern code change the substream matrix is treated in
different ways depending whether it is a shading or a tiling pattern. Maybe
this is due to the "design by committee" structure of PDF that it is different,
or maybe I'm mistaken somewhere. (however any code change in PDPattern to make
it similar results in bad rendering)
was (Author: tilman):
I always understood your comment the way you meant it in the first place. I
never tried (1), mostly because... I didn't understand it. What I did is (2)
(use the xform), plus your comment from March (use the substream start matrix)
because this worked with the PDFBOX-1442 shading patterns, and my small own
improvement to use the correct translation source (BBox lower left instead of
full rectangle lower left). What I mean is that except for the xform part, I
implemented your sugestion (from March).
I know there's room for improvement, see my previous comment. It is somewhat
suspicious that in PDPattern the substream matrix is treated in different ways
depending whether it is a shading or a tiling pattern. Maybe this is due to the
"design by committee" structure of PDF that it is different, or maybe I'm
mistaken somewhere.
> Pattern colorspace support
> --------------------------
>
> Key: PDFBOX-1094
> URL: https://issues.apache.org/jira/browse/PDFBOX-1094
> Project: PDFBox
> Issue Type: Improvement
> Components: Rendering
> Affects Versions: 1.6.0
> Reporter: Andreas Lehmkühler
> Priority: Minor
> Attachments: ColoredTilingPaint.patch, PATTYP1.pdf, PATTYP2.pdf,
> PDF32000_2008_pg737.pdf, PDFBOX-1094-065514-XStep32767.pdf,
> PDFBOX-1094-094730.pdf, PDFBOX-1094-096213-p18.pdf,
> PDFBOX-1861-tracemonkey13.png, PDFStreamEngine.patch, PageDrawer.patch,
> _pdfbox-1094-tiling_pattern.pdf-1-blurry.png, gs-bugzilla693653.pdf,
> jagpdf_doc_patterns.pdf, jagpdf_doc_patterns.pdf-1.png,
> pdfbox-1094-pdf32000_2008_pg737.pdf-1.png,
> pdfbox-1094-pdf32000_2008_pg737.pdf-1.png,
> pdfbox-1094-tiling_pattern.pdf-1.png, pdfbox-1094-tiling_pattern.pdf-1.png,
> pdfbox-1094-tiling_pattern.pdf-1.png, pdfbox-1861-tracemonkey.pdf-13.png,
> pdfbox-1861-tracemonkey.pdf-13.png, tiling_pattern.pdf
>
>
> PDFBox doesn't support PDPattern colorspaces
--
This message was sent by Atlassian JIRA
(v6.2#6252)
