[ https://issues.apache.org/jira/browse/PDFBOX-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116583#comment-14116583 ]
John Hewson edited comment on PDFBOX-1094 at 8/31/14 8:45 AM: -------------------------------------------------------------- Yeah it's a good start, mixing both techniques is ultimately what's needed, if not a little more difficult to reason about. Currently the code doesn't quite do what was suggested in (2): {quote} Have PageDrawer extract the initial scale from Graphics2D#getTransform {quote} At the moment graphics.getTransform() is being called when the pattern is to be drawn, but that transform might include subsequent changes to the CTM since the start of the stream. What I had in mind with the "initial scale" was to capture the initial transform of the Graphics2D canvas which we're drawing to, at the very beginning, before any rendering has begun. i.e. we're just trying to capture the DPI of the underlying graphics device, so that we can have our AWT paint render at 2x or 4x etc. and avoid blocky rendering. Then your "subStreamMatrix" can handle all the extra PDF spec stuff, excluding the DPI. was (Author: jahewson): Yeah it's a good start, mixing both techniques is ultimately what's needed, if not a little more difficult to reason about. Currently the code doesn't quite do what was suggested in (1): {quote} Have PageDrawer extract the initial scale from Graphics2D#getTransform {quote} At the moment graphics.getTransform() is being called when the pattern is to be drawn, but that transform might include subsequent changes to the CTM since the start of the stream. What I had in mind with the "initial scale" was to capture the initial transform of the Graphics2D canvas which we're drawing to, at the very beginning, before any rendering has begun. i.e. we're just trying to capture the DPI of the underlying graphics device, so that we can have our AWT paint render at 2x or 4x etc. and avoid blocky rendering. Then your "subStreamMatrix" can handle all the extra PDF spec stuff, excluding the DPI. > Pattern colorspace support > -------------------------- > > Key: PDFBOX-1094 > URL: https://issues.apache.org/jira/browse/PDFBOX-1094 > Project: PDFBox > Issue Type: Improvement > Components: Rendering > Affects Versions: 1.6.0 > Reporter: Andreas Lehmkühler > Priority: Minor > Attachments: ColoredTilingPaint.patch, PATTYP1.pdf, PATTYP2.pdf, > PDF32000_2008_pg737.pdf, PDFBOX-1094-065514-XStep32767.pdf, > PDFBOX-1094-094730.pdf, PDFBOX-1094-096213-p18.pdf, > PDFBOX-1861-tracemonkey13.png, PDFStreamEngine.patch, PageDrawer.patch, > _pdfbox-1094-tiling_pattern.pdf-1-blurry.png, gs-bugzilla693653.pdf, > jagpdf_doc_patterns.pdf, jagpdf_doc_patterns.pdf-1.png, > pdfbox-1094-pdf32000_2008_pg737.pdf-1.png, > pdfbox-1094-pdf32000_2008_pg737.pdf-1.png, > pdfbox-1094-tiling_pattern.pdf-1.png, pdfbox-1094-tiling_pattern.pdf-1.png, > pdfbox-1094-tiling_pattern.pdf-1.png, pdfbox-1861-tracemonkey.pdf-13.png, > pdfbox-1861-tracemonkey.pdf-13.png, tiling_pattern.pdf > > > PDFBox doesn't support PDPattern colorspaces -- This message was sent by Atlassian JIRA (v6.2#6252)