[ https://issues.apache.org/jira/browse/PDFBOX-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116495#comment-14116495 ]
John Hewson edited comment on PDFBOX-1094 at 8/30/14 8:15 PM: -------------------------------------------------------------- Looking at the code, what you've done is to try and do (1) and (2) at the same time using your own approach which we haven't discussed. It would be much better to get (2) working first and then we can discuss (1) having hopefully gained some insight. I'm confident that the code you've added to tackle (1) isn't going to work in the long run but that's not the discussion we should be having right now... let's just solve (2) first and then figure out (1) cleanly afterwards? EDIT: the original version of this comment had the numbers 1 and 2 the wrong way around. was (Author: jahewson): Looking at the code, what you've done is to try and do (1) and (2) at the same time using your own approach which we haven't discussed. It would be much better to get (1) working first and then we can discuss (2) having hopefully gained some insight. I'm confident that the code you've added to tackle (2) isn't going to work in the long run but that's not the discussion we should be having right now... let's just solve (1) first and then figure out (2) cleanly afterwards? > Pattern colorspace support > -------------------------- > > Key: PDFBOX-1094 > URL: https://issues.apache.org/jira/browse/PDFBOX-1094 > Project: PDFBox > Issue Type: Improvement > Components: Rendering > Affects Versions: 1.6.0 > Reporter: Andreas Lehmkühler > Priority: Minor > Attachments: ColoredTilingPaint.patch, PATTYP1.pdf, PATTYP2.pdf, > PDF32000_2008_pg737.pdf, PDFBOX-1094-065514-XStep32767.pdf, > PDFBOX-1094-094730.pdf, PDFBOX-1094-096213-p18.pdf, > PDFBOX-1861-tracemonkey13.png, PDFStreamEngine.patch, PageDrawer.patch, > _pdfbox-1094-tiling_pattern.pdf-1-blurry.png, gs-bugzilla693653.pdf, > jagpdf_doc_patterns.pdf, jagpdf_doc_patterns.pdf-1.png, > pdfbox-1094-pdf32000_2008_pg737.pdf-1.png, > pdfbox-1094-pdf32000_2008_pg737.pdf-1.png, > pdfbox-1094-tiling_pattern.pdf-1.png, pdfbox-1094-tiling_pattern.pdf-1.png, > pdfbox-1094-tiling_pattern.pdf-1.png, pdfbox-1861-tracemonkey.pdf-13.png, > pdfbox-1861-tracemonkey.pdf-13.png, tiling_pattern.pdf > > > PDFBox doesn't support PDPattern colorspaces -- This message was sent by Atlassian JIRA (v6.2#6252)