ruojieranyishen commented on code in PR #2162:
URL: 
https://github.com/apache/incubator-pegasus/pull/2162#discussion_r1872507606


##########
admin-cli/executor/disk_info.go:
##########
@@ -97,6 +99,31 @@ func QueryAllNodesDiskInfo(client *Client, tableName string) 
(map[string]*radmin
        return respMap, nil
 }
 
+func QueryAliveNodesDiskInfo(client *Client, tableName string) 
(map[string]*radmin.QueryDiskInfoResponse, error) {

Review Comment:
   The original QueryNodesDiskInfo was not user-friendly and couldn't handle 
certain situations, such as missing table partition on nodes or some nodes 
being unalive. Should I submit a new PR?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to