ruojieranyishen commented on code in PR #2162:
URL:
https://github.com/apache/incubator-pegasus/pull/2162#discussion_r1883283925
##########
admin-cli/executor/client.go:
##########
@@ -45,14 +46,18 @@ type Client struct {
}
// NewClient creates a client for accessing Pegasus cluster for use of
admin-cli.
-func NewClient(writer io.Writer, metaAddrs []string) *Client {
+// When listing nodes fails, willExit == true means call os.Exit().
+func NewClient(writer io.Writer, metaAddrs []string, willExit bool) (*Client,
error) {
Review Comment:
The context is that I am estimating the required disk space for a bulk load
on the Pegasus gateway using admincli, but currently, admincli does not support
disconnect tcp from the replica server.
When using admincli to connect to the Pegasus cluster, it should not call
the os.Exit function; it should only return an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
