ruojieranyishen commented on code in PR #2162:
URL:
https://github.com/apache/incubator-pegasus/pull/2162#discussion_r1899937708
##########
admin-cli/executor/client.go:
##########
@@ -65,5 +70,24 @@ func NewClient(writer io.Writer, metaAddrs []string) *Client
{
Meta: meta,
Nodes: util.NewPegasusNodeManager(metaAddrs, replicaAddrs),
Perf: aggregate.NewPerfClient(metaAddrs),
+ }, nil
+}
+
+func CloseClient(client *Client) error {
+ var errorStrings []string
+ err := client.Meta.Close()
+ if err != nil {
+ fmt.Printf("Error: failed to close meta session [%s]\n", err)
+ errorStrings = append(errorStrings, err.Error())
Review Comment:
Thinks, I agree and modify code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
