empiredan commented on code in PR #2162:
URL:
https://github.com/apache/incubator-pegasus/pull/2162#discussion_r1883241486
##########
admin-cli/executor/client.go:
##########
@@ -45,14 +46,18 @@ type Client struct {
}
// NewClient creates a client for accessing Pegasus cluster for use of
admin-cli.
-func NewClient(writer io.Writer, metaAddrs []string) *Client {
+// When listing nodes fails, willExit == true means call os.Exit().
+func NewClient(writer io.Writer, metaAddrs []string, willExit bool) (*Client,
error) {
Review Comment:
When `willExit` would be set `false` ? Is it necessary to add the param ?
And returned error is also be ignored, is it needed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
