[ 
https://issues.apache.org/jira/browse/PHOENIX-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134799#comment-14134799
 ] 

ASF GitHub Bot commented on PHOENIX-1198:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/15#discussion_r17578973
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ---
    @@ -214,11 +218,16 @@ public boolean prune(PTable table) {
     
             // setup tracing, if its enabled
             this.sampler = Tracing.getConfiguredSampler(this);
    +        this.customTracingAnnotations = 
ImmutableMap.copyOf(JDBCUtil.getCustomTracingAnnotations(url, info));
    --- End diff --
    
    How about adding a custom annotation for known properties like TENANT_ID 
and CURRENT_SCN?


> Add ability to pass custom tags to be added to log lines
> --------------------------------------------------------
>
>                 Key: PHOENIX-1198
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1198
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Eli Levine
>            Assignee: Eli Levine
>             Fix For: 5.0.0, 4.1
>
>
> These tags can be passed in either when creating connections or calling 
> upsert/select. Similar to PHOENIX-1196. Maybe they can shared the same 
> mechanism for passing in values to be logged/traced.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to