[
https://issues.apache.org/jira/browse/PHOENIX-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249561#comment-14249561
]
ramkrishna.s.vasudevan commented on PHOENIX-1514:
-------------------------------------------------
{code}
+ if (this.getClass() != obj.getClass()) return false;
{code}
This change is to avoid the classCastException in the impl of every type?
Fine. Better to add that. Previously also for every type we had equals() impl
but was expecting both the objects to be of double[].
The isSizeCompatible also looks fine considering the way
convertObjectArrayToPrimitiveArray() is now done.
> Break up PDataType Enum
> -----------------------
>
> Key: PHOENIX-1514
> URL: https://issues.apache.org/jira/browse/PHOENIX-1514
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 5.0.0
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Fix For: 5.0.0
>
> Attachments: PHOENIX-1514.00.patch, PHOENIX-1514.01.patch,
> PHOENIX-1514.02.patch, PHOENIX-1514.04.patch, hung-phoenix-verify.txt,
> stack.txt
>
>
> A first step in adopting (a portion of) HBase's type encodings is to break up
> the PDataType enum into an interface. This will pave the way for more
> flexibility going forward.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
