[
https://issues.apache.org/jira/browse/PHOENIX-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249084#comment-14249084
]
Nick Dimiduk commented on PHOENIX-1514:
---------------------------------------
Yes, if i change equals i'll tweak hash code accordingly.
Re: the above change, it's too strict. I'm seeing UT failures such as
{noformat}
testForUnSignedLongArray(org.apache.phoenix.schema.PDataTypeForArraysTest)
Time elapsed: 0.003 sec <<< ERROR!
java.lang.ClassCastException:
org.apache.phoenix.schema.types.PhoenixArray$PrimitiveLongPhoenixArray cannot
be cast to
org.apache.phoenix.schema.types.PhoenixArray$PrimitiveDoublePhoenixArray
at
org.apache.phoenix.schema.types.PhoenixArray$PrimitiveLongPhoenixArray.equals(PhoenixArray.java:362)
at org.junit.Assert.isEquals(Assert.java:131)
at org.junit.Assert.equalsRegardingNull(Assert.java:127)
at org.junit.Assert.assertEquals(Assert.java:111)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.phoenix.schema.PDataTypeForArraysTest.testForUnSignedLongArray(PDataTypeForArraysTest.java:887)
{noformat}
> Break up PDataType Enum
> -----------------------
>
> Key: PHOENIX-1514
> URL: https://issues.apache.org/jira/browse/PHOENIX-1514
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 5.0.0
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Fix For: 5.0.0
>
> Attachments: PHOENIX-1514.00.patch, PHOENIX-1514.01.patch,
> PHOENIX-1514.02.patch, hung-phoenix-verify.txt, stack.txt
>
>
> A first step in adopting (a portion of) HBase's type encodings is to break up
> the PDataType enum into an interface. This will pave the way for more
> flexibility going forward.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
