[ 
https://issues.apache.org/jira/browse/PIG-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598470#comment-13598470
 ] 

Prashant Kommireddi commented on PIG-2591:
------------------------------------------

Hey [~jarcec] [~cheolsoo] correct me if I am wrong but the patch does not pick 
up temporary directory from system properties. I think the JIRA was intended to 
pick the temp dir from system properties? "pig.temp.dir" is used for specifying 
the temporary directory (local, hdfs) for storing intermediate data between MR 
jobs. Does it make more sense to pick up base path for tests from system props 
instead?

I like the approach otherwise, it's a rather large effort to change all tests 
in the same patch to use this.
                
> Unit tests should not write to /tmp but respect java.io.tmpdir
> --------------------------------------------------------------
>
>                 Key: PIG-2591
>                 URL: https://issues.apache.org/jira/browse/PIG-2591
>             Project: Pig
>          Issue Type: Bug
>          Components: tools
>            Reporter: Thomas Weise
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 0.12
>
>         Attachments: bugPIG-2591.patch, PIG-2495.patch
>
>
> Several tests use /tmp but should derive temporary file location from 
> java.io.tmpdir to avoid side effects (java.io.tmpdir is already set to a test 
> run specific location in build.xml)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to