[ 
https://issues.apache.org/jira/browse/PIG-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598563#comment-13598563
 ] 

Jarek Jarcec Cecho commented on PIG-2591:
-----------------------------------------

Hi [~cheolsoo] and [~prkommireddi],
thank you very much for your feedback. I agree with proposed steps and I'll be 
more than happy to execute them myself. I just have small comment, direct usage 
of {{FileLocalizer}} is not simple as it requires a lot of initialization (for 
example that class needs valid {{PigContext}}). Thus I would propose to move 
the actual logic of getting temporary directory into standalone easily reusable 
class {{TmpUtil}} (which is part of {{bugPIG-2591.patch}}).

Jarcec
                
> Unit tests should not write to /tmp but respect java.io.tmpdir
> --------------------------------------------------------------
>
>                 Key: PIG-2591
>                 URL: https://issues.apache.org/jira/browse/PIG-2591
>             Project: Pig
>          Issue Type: Bug
>          Components: tools
>            Reporter: Thomas Weise
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 0.12
>
>         Attachments: bugPIG-2591.patch, PIG-2495.patch
>
>
> Several tests use /tmp but should derive temporary file location from 
> java.io.tmpdir to avoid side effects (java.io.tmpdir is already set to a test 
> run specific location in build.xml)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to