[ 
https://issues.apache.org/jira/browse/PIG-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599098#comment-13599098
 ] 

Prashant Kommireddi commented on PIG-2591:
------------------------------------------

[~cheolsoo] I agree with your assessment. 

{quote}
I was wrong about setting "pig.temp.dir" in system properties in build.xml for 
unit tests. In fact, it won't be propagated to PigContext. So we should set 
"pig.temp.dir" in PigContext. {quote}
That was partly a cause for my confusion :). Setting a system property would 
not reflect in PigContext.

[~jarcec] apologies for the back-and-forth and thanks for your patience. But 
it's important we all agree on the best approach as this patch affects the way 
we write and run tests :)


                
> Unit tests should not write to /tmp but respect java.io.tmpdir
> --------------------------------------------------------------
>
>                 Key: PIG-2591
>                 URL: https://issues.apache.org/jira/browse/PIG-2591
>             Project: Pig
>          Issue Type: Bug
>          Components: tools
>            Reporter: Thomas Weise
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 0.12
>
>         Attachments: bugPIG-2591.patch, PIG-2495.patch
>
>
> Several tests use /tmp but should derive temporary file location from 
> java.io.tmpdir to avoid side effects (java.io.tmpdir is already set to a test 
> run specific location in build.xml)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to