[ 
https://issues.apache.org/jira/browse/PIG-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598620#comment-13598620
 ] 

Cheolsoo Park commented on PIG-2591:
------------------------------------

PIG-2995 explains the reasoning. I think that the advantage of having a 
property such as "pig.temp.dir" is to use it on a case-by-case basis without 
having to changing code. So I don't understand why setting the property to 
different values for different purposes is confusing.

As far as I understand, both PIG-2995 and PIG-2591 are trying to solve the same 
problem. When you have automated builds, you want to control where builds 
generate temporary files. In fact, there are two kinds of files that tests 
generate. As you pointed out, 1) intermediate files and 2) output files (e.g. 
STORE foo INTO '/tmp'). To me, controlling them with a single property sounds 
better rather than having two properties.

Does this make sense?
                
> Unit tests should not write to /tmp but respect java.io.tmpdir
> --------------------------------------------------------------
>
>                 Key: PIG-2591
>                 URL: https://issues.apache.org/jira/browse/PIG-2591
>             Project: Pig
>          Issue Type: Bug
>          Components: tools
>            Reporter: Thomas Weise
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 0.12
>
>         Attachments: bugPIG-2591.patch, PIG-2495.patch
>
>
> Several tests use /tmp but should derive temporary file location from 
> java.io.tmpdir to avoid side effects (java.io.tmpdir is already set to a test 
> run specific location in build.xml)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to