Just played around with @BXML, and don't see much value there. However, I do favour more documentation when practical, especially when it is automatically generated and therefore kept in sync.
How about I just add the @Documented to all 3? Chris On 8 August 2011 20:15, Greg Brown <gk_br...@verizon.net> wrote: > IDProperty might benefit. Not sure about @BXML, but probably. > > On Aug 8, 2011, at 9:06 AM, Chris Bartlett wrote: > >> I thought they were included by default (if you can excuse the pun), >> but only realised that DefaultProperty wasn't when I went looking for >> it just now. >> >> I take it you have no objection to me adding it then? >> Any thoughts about other Pivot annotations? >> >> On 8 August 2011 20:02, Greg Brown <gk_br...@verizon.net> wrote: >>> That's cool - I was not aware of that feature. >>> >>> On Aug 8, 2011, at 8:39 AM, Chris Bartlett wrote: >>> >>>> Is there any reason why the DefaultProperty annotation is not >>>> annotated itself with java.lang.annotation.Documented? >>>> >>>> Doing so means that users will be able to see what WTK (or other) >>>> classes are have the DefaultProperty annotation and its value by >>>> looking at the Javadoc for that class. >>>> >>>> Are there any other Pivot annotations which would also benefit from this? >>>> >>>> Index: DefaultProperty.java >>>> =================================================================== >>>> --- DefaultProperty.java (revision 1153814) >>>> +++ DefaultProperty.java (working copy) >>>> @@ -16,6 +16,7 @@ >>>> */ >>>> package org.apache.pivot.beans; >>>> >>>> +import java.lang.annotation.Documented; >>>> import java.lang.annotation.ElementType; >>>> import java.lang.annotation.Inherited; >>>> import java.lang.annotation.Retention; >>>> @@ -26,6 +27,7 @@ >>>> * Specifies a property to which child elements will be added or set when >>>> an >>>> * explicit property is not given. >>>> */ >>>> +@Documented >>>> @Inherited >>>> @Retention(RetentionPolicy.RUNTIME) >>>> @Target(ElementType.TYPE) >>> >>> > >
