Hi all,
with the help of the Karaf Community and especially @Christian Schneider I was
able to finalize a PR which makes PLC4X fully OSGi-compatible:
https://github.com/apache/plc4x/pull/89
This means that all jars are also valid (and hopefully correct) OSGi Bundles.
Furthermore, I introduced a Karaf Feature fort he S7 driver (which I already
tested manually and it works).
Despite some pom additions I had to do a slight refactoring and rename several
packages to avoid package-split situations.
Thus, please review my PR carefully (although I consider all of those minor).
Thanks!
Julian
PS.: I think we really should take this into 0.5 release
Am 08.10.19, 15:26 schrieb "Christofer Dutz" <christofer.d...@c-ware.de>:
I agree ... as far as I understand it it's just some text in the MANIFEST
that doesn't have impact on other class loading systems.
We should check how we get this additional data in there however. There are
multiple options and I don't quite know how good all of them are.
Chris
Am 08.10.19, 10:07 schrieb "Sebastian Rühl"
<sebastian.ruehl...@googlemail.com.INVALID>:
Hi Julian,
We should put the osgi metadata directly into the modules as they
„just“ enhance the manifest.
Additional JARs would only increase the complexity.
Sebastian
> Am 07.10.2019 um 15:58 schrieb Julian Feinauer
<j.feina...@pragmaticminds.de>:
>
> Hi all,
>
> as some of you may have notices from Twitter or Slack I am currently
working on integrating PLC4X into OSGi and especially Karaf.
> I get a lot of help from the Karaf guys and also Lukasz joined the
effort to get this done, finally : )
>
> For the Drivers, there is one “central” question.
> Do we want the Driver jars to also be OSGi-Bundles or do we prefer
separate jars with a 1-1 relationship as OSGi bundles.
> Other projects, like Netty do it all in one
(https://netty.io/wiki/new-and-noteworthy-in-4.0.html).
> In fact, the only difference is a “META-INF/MANIFEST.MF” file which
is there additionally. So it hurts nobody but helps OSGi users.
>
> What are your thoughts on that?
>
> Julian
