jsxs0 commented on PR #2010: URL: https://github.com/apache/plc4x/pull/2010#issuecomment-2667337253
@chrisdutz I've made some changes: 1. Is the alignment with s7.mspec correct, I mean, for parameter types? 2. Are there any protocol features missing from this initial implementation? 3. Is the error handling approach sufficient for industrial use? 4. Should we add more specific test cases? --- For now, I'm thinking of the following next steps: 1. Add async connection handling 2. Implement message serialization 3. Add more protocol-specific error cases 4. Expand test coverage 5. Add documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
