jsxs0 commented on PR #2010: URL: https://github.com/apache/plc4x/pull/2010#issuecomment-2705614346
@chrisdutz Thanks for the feedback! I've made all the changes you requested: 1. Renamed the directory to `plc4rs` and removed the old `plc4x-rust` directory 2. Added Apache license headers to all files (Rust source files, Cargo.toml, etc.) 3. Set up the Maven integration with your pom.xml file 4. Added the `with-rust` profile to the parent pom.xml The build now works with `mvn -Pwith-rust clean install` and passes all the license checks. There are still some Rust warnings about unused variables, but those don't affect the build. I've also added a README with basic usage instructions and updated the project structure to match PLC4X conventions. Let me know if there's anything else I should fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
