chrisdutz commented on PR #2010: URL: https://github.com/apache/plc4x/pull/2010#issuecomment-2668106207
I guess in order to review the actual code, it would probably help, if I understood Rust ;-) I can give you some pointers to what's generally important when bringing plc4x to new languages: - Build an SPI, so a lot of the general purpose code can be shared among protocol-drivers - Support the concept of transports: serial, udp, tcp, (raw-socket) ... and "test" The following would be for when the code-gen has generally been implemented: - Implement a runner to run the xml-based ParserSerializer tests (That are deployed along the mspec-protocol modules) against your generated code - Implement a runner to run the xml-based Integration tests (That are deployed along the mspec-protocol modules) against your driver I'll try to have a look and play around with your driver. Thanks for contributing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
