QuanticPony opened a new pull request, #336: URL: https://github.com/apache/plc4x-extras/pull/336
Based on PR by @ottobackwards https://github.com/apache/plc4x-extras/pull/52 Even if NiFi community recommends migrating to NiFi 2 a large part will surely still be using NiFi 1 for a long time. Right now to use PLC4X on NiFi 2 requires doing manual changes on the code by the users of PLC4X. The needed changes on plc4x-extras are not that big. Maybe we could make two nars, one for each NiFi major version, at least for the next PLC4X release. ```bash mvn clean package # -> for NiFi 1 mvn clean package -P nifi2 # -> for NiFi 2. Requires Java 21 ``` This would create two nars: plc4j-nifi-plc4x-nar-0.13.0-SNAPSHOT.nar plc4j-nifi-plc4x-nar-0.13.0-SNAPSHOT-nifi2.nar I have tested both NiFi 1 and 2 nars and seems to be working fine I'm not sure about the NiFi2Compatibility.java on this PR. May be an unusual way of making something like this. Let me know what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
