potiuk commented on PR #321: URL: https://github.com/apache/incubator-ponymail-foal/pull/321#issuecomment-4887002373
Thanks — you're right. The spurious churn was all in `server/endpoints/preferences.py` (quote-style and spacing changes unrelated to the feature); I've reverted those so the file now carries only the two functional changes it needs. I checked the rest of the diff too: the other pre-existing files are purely additive, and the `?revision=` bumps in the HTML/JS are just the usual generated-file cache-busting, not reformatting. If you spot any other spurious changes, let me know and I'll strip them out. On the size of the PR more generally: I'm happy to split it into a series of smaller, independently reviewable PRs if that's easier. A natural sequence would be: 1. **Token data model & config** — the `token` ES mapping + `token.py` plugin (generation, hashing, scopes, expiry), config keys + `ponymail.yaml.example`, and the background reaper for expired tokens. No user-facing behaviour yet. 2. **Auth integration** — `Authorization: Bearer <token>` validation in `session.py`, the logout guard for token sessions, and the `auditlog` refresh-policy param. This is what makes tokens actually authenticate requests. 3. **REST endpoint** — the `/api/token` create/list/revoke endpoint, route registration, and the OpenAPI spec. 4. **Web UI** — the "API Tokens" preferences panel (`tokens.js` + generated assets). 5. **Docs & tests** — API docs, client guide, and `test_token.py` (or folded into each PR above). Happy to go that route, or to adjust the split — and happy to address any other comments you have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
