potiuk commented on PR #321: URL: https://github.com/apache/incubator-ponymail-foal/pull/321#issuecomment-4887601638
`sebbASF` Cleaned up and pushed. The whitespace/quote churn is gone — I squashed it back into the original change, so `preferences.py` now carries only its two functional edits. The PR is now just two commits: 1. [`5e8d3ec`](https://github.com/apache/incubator-ponymail-foal/pull/321/commits/5e8d3ec8355eff4cd884ccb6e156145b264f642a) — all the source changes (including the spacing/quoting, now folded in). 2. [`f427fc0`](https://github.com/apache/incubator-ponymail-foal/pull/321/commits/f427fc097138bbb82e7ca59cb356ea267b23e962) — the result of running `webui/js/source/build.sh` (and `server/update_version.sh`) on those sources: the regenerated `ponymail.js`, the `?revision=` cache-busting stamps, and `server_version.py`. This is precisely the "commit the source first, then run `build.sh` and commit the built files separately" step described in AGENTS.md. Before I take it further, how would you prefer this structured? - **Keep it as one PR** (source commit + generated commit), as it is now. - **Split into a series of smaller stacked PRs** — I sketched a proposed breakdown above. - **Drop the generated commit entirely** — e.g. if those files are meant to be regenerated at build/release time and you'd rather not carry them through review. Happy to do whichever you prefer — just let me know which. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
