potiuk commented on PR #321: URL: https://github.com/apache/incubator-ponymail-foal/pull/321#issuecomment-4887683629
`sebbASF` Dropped the generated commit — the PR is now a single commit ([`5e8d3ec`](https://github.com/apache/incubator-ponymail-foal/pull/321/commits/5e8d3ec8355eff4cd884ccb6e156145b264f642a)) with just the source changes; `ponymail.js`, the `?revision=` stamps, and `server_version.py` are untouched and back to their master state. That said, I'm open on how to handle the generated files — whatever fits your workflow best: - **Leave them out entirely** (as now) and regenerate at build/release time. - **Add them back as a separate follow-up commit/PR** once the source is reviewed and merged. - **Bundle them back into this PR** as a second commit if you'd rather the branch be directly deployable. Just let me know which you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
