potiuk commented on PR #321: URL: https://github.com/apache/incubator-ponymail-foal/pull/321#issuecomment-4887567688
> Are the version changes absolutely necessary? If not, then remove them. They are a natural consequence of how it is built - if you look at the AGENTS.md of ponymail, the PRs that are supposed to be opened here are supposed to be split into two commits: a) change b) generated API change I am strictly following those expectations (or at least this is how I understand them): This is what is written in AGENTS.md > After editing source files: commit the source changes first, then run build.sh and commit the built ponymail.js separately This is how my PR is created: First commit: https://github.com/apache/incubator-ponymail-foal/pull/321/changes/732f8e292e6f30208eaef7ea0c62440c7504aae1 - > first commit wiht only source changes Second comit - which contains generated code (and this is where versions are changed): https://github.com/apache/incubator-ponymail-foal/pull/321/changes/b1d350e069a00cff26bd1aef07d710c5bda5c25d There is now also 3rd-commit with space removal after your comments @sebb - so let me rebase it back to only two commits. Are you telling me @sebbASF that those should be two PR stacked on top of each other? or should I not commit the generated files at all (contrary to what is written in the docs?) - can you please clarify how exactly to commit javasript changes? I think if I do not generate the files in a separate PR, merging the "just sources" PR migh be not possible or PR might be red - but I would love some clarification on how to do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
