gemmellr commented on a change in pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#discussion_r745487442
##########
File path:
qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnectionFactory.java
##########
@@ -591,6 +613,14 @@ public long getConnectTimeout() {
return this.connectTimeout;
}
+ public void setCompletionThreads(final int completionThreads) {
Review comment:
Ok, I had forgotten that bit in the ConnectionFactory by the time my
head spun around from all the other bits, so it is indeed doing per-factory
sharing.
Its still not what I expected you to do, given it means that every factory
would result in its own pool. Folks can have more than one factory, rather than
just creating all connections on a single given factory, and from prior
discussion it seems like you really cared about all the different connections
sharing, so I rather expected you to do all-connection sharing when they were
configured with this option.
That would introduce a similar issue to the other JIRA/PR, where people
might have different configurations that then needs different pools here...but
that seems like it would be easily solved in a pretty similar way, effectively
just a map of different setups to match against.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
