gemmellr commented on a change in pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#discussion_r745580710
##########
File path:
qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnectionFactory.java
##########
@@ -591,6 +613,14 @@ public long getConnectTimeout() {
return this.connectTimeout;
}
+ public void setCompletionThreads(final int completionThreads) {
Review comment:
I've seen both approaches. Neither is unusual. It really just depends
what they are doing.
E.g if they are configuring ClientID's on the factory, they can necessarily
only create 1 connection [at a time] with that factory, and might have more
than one. Different frameworks, different config.
I would typically expect them to use the same config for options like this
even if they do...but, really nothing requires they do that, and it may not
always be in their control that they do, so it should work if they dont. Same
as comments on the other PR, really.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
