franz1981 commented on a change in pull request #44:
URL: https://github.com/apache/qpid-jms/pull/44#discussion_r745531504
##########
File path:
qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnectionFactory.java
##########
@@ -591,6 +613,14 @@ public long getConnectTimeout() {
return this.connectTimeout;
}
+ public void setCompletionThreads(final int completionThreads) {
Review comment:
> That would introduce a similar issue to the other JIRA/PR, where
people might have different configurations that then needs different pools
here...but that seems like it would be easily solved in a pretty similar way,
effectively just a map of different setups to match against.
This can be done creating some "leaky" (by purpose) singleton shared map
with per-configuration pool, but is it a valid use case?
Or the typical use case is to have a single factory per-application?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
