Done. To summarise here though: 1. QPID-3109: looks good, although as mentioned on the JIRA a second commit http://svn.apache.org/viewvc?view=rev&rev=1079059 is also required here, to enable compilation to succeed.
2. & 3. QPID-2732: changes look reasonable. 4. This specific change looks good to restore the prior behaviour, though in general I wouldn't consider work around change of accept mode to be very low risk. I would suggest there should have been tests added to verify the behaviour of the original change that caused the issue though (same goes for all really). Robbie -----Original Message----- From: Justin Ross [mailto:[email protected]] Sent: 08 March 2011 18:08 To: [email protected] Subject: Re: Request for the following commits to be included in 0.10 Hi, Rajith. I approved item 4. Robbie, would you indicate briefly up or down for 0.10 in the comments of qpid-3109 and -2732? Justin On Tue, 8 Mar 2011, Rajith Attapattu wrote: > Hi Justin, > > I'd like the following commits to be included in the 0.10 release branch. > > 1. http://svn.apache.org/viewvc?rev=1078961&view=rev - QPID-3109 - > Fairly low risk. > This is a simple bug fix. > > 2. http://svn.apache.org/viewvc?rev=1078971&view=rev - QPID-2732 - > Low risk. > This is an addition to the initial commit made under this JIRA. > It adds default reliability modes and throws an exception for an > unsupported combination. > > 3. http://svn.apache.org/viewvc?rev=1079408&view=rev - QPID-2732 - Low Risk > The reliability mode is used to mark a transfer unreliable and that > flag is used to determine if a transfer should be stored for replay or not. > Again a fairly straightforward and low risk commit. However I have > asked Rafi to have a quick look at it as well. > > 4. http://svn.apache.org/viewvc?rev=1079402&view=rev - QPID-3127 - > Very low risk. > Fixes a bug in the initial commit for QPID-2732. > It just sets accept mode to NONE for NO_ACKNOWLEDGE. > > Regards, > > Rajith > --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected] --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
