Andrew, I did do a grep on "NO_ACKNOWLEDGE" and saw those test cases. Thanks for confirming. Just wanted to make sure I verified the changes properly.
Btw does the various QueueBrowser tests pass for you ? Rajith On Wed, Mar 9, 2011 at 4:55 PM, Andrew Kennedy < andrewinternatio...@gmail.com> wrote: > Yes, > > > ./systests/src/main/java/org/apache/qpid/test/unit/ack/Acknowledge2ConsumersTest.java > > ./systests/src/main/java/org/apache/qpid/test/unit/ack/AcknowledgeOnMessageTest.java > > ./systests/src/main/java/org/apache/qpid/test/unit/ack/AcknowledgeAfterFailoverOnMessageTest.java > ./systests/src/main/java/org/apache/qpid/test/unit/ack/AcknowledgeTest.java > > ./systests/src/main/java/org/apache/qpid/test/unit/ack/AcknowledgeAfterFailoverTest.java > > The AcknowledgeTest class has a test called 'testNoAck' which exercises > this mode, and all the other classes extend this. This is how I both > discovered and confirmed the fix for the regression. > > > Andrew. > -- > -- andrew d kennedy ? do not fold, bend, spindle, or mutilate ; > -- http://grkvlt.blogspot.com/ ? edinburgh : +44 7582 293 255 ; > > On 9 Mar 2011, at 20:47, Rajith Attapattu wrote: > > In rev 1079986 I added test cases for the reliability options including >> testing if the correct accept modes are set. >> I am wondering if there are existing test cases for NO_ACKNOWLEDGE other >> than the QueueBrowser test cases ? >> >> Regards, >> >> Rajith >> >> On Tue, Mar 8, 2011 at 8:52 PM, Andrew Kennedy < >> andrewinternatio...@gmail.com> wrote: >> >> On 9 Mar 2011, at 00:40, Robbie Gemmell wrote: >> >> Sorry if I wasn't clear. I wasn't saying it shouldn't go in, quite the >> opposite; in general I wouldn't allow this kind of change at this point, >> but >> in this particular case it is actually putting something back roughly the >> way it was until changed a few days ago so I would actually say that it >> must >> be put in. >> >> +1 on including #4 in 0.10 >> >> When we discovered and fixed this, we weren't actually aware it was a >> regression introduced recently, hence the separate JIRA and careful testing. >> >> Andrew. >> -- >> -- andrew d kennedy ? do not fold, bend, spindle, or mutilate ; >> -- http://grkvlt.blogspot.com/ ? edinburgh : +44 7582 293 255 ; >> >> >> --------------------------------------------------------------------- >> Apache Qpid - AMQP Messaging Implementation >> Project: http://qpid.apache.org >> Use/Interact: mailto:dev-subscr...@qpid.apache.org >> >> >> >
