[
https://issues.apache.org/jira/browse/QPID-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061497#comment-13061497
]
Rajith Attapattu commented on QPID-3342:
----------------------------------------
Robbie,
This is a significant amount of code that has been committed with zero review
or discussion.
I will comment on the changes later, but overall I am quite disappointed in the
way this was done !
1. The commit was made, just a few hours after the patches were attached to the
JIRA.
2. For a change of this magnitude I would have appreciated if it was put up for
review first. It's only fair to do so as lot of others folks in the project are
doing it.
3. There is no summary or a design doc that explains what's been done or what
exactly the vision here is. When Andrew Kennedy attempted to do this, he had
detailed JIRA's and a decent design doc.
4. I can't seem to find if transports are configurable or not - i.e the
existing mechanism for loading transports via Reflection was removed without a
replacement. This was done for a reason and I have repeatedly stressed this on
the JIRA's created by Andrew.
I will comment on some of the code changes separately. Again I am not happy
with the way these changes were done.
Rajith
> Rationalise transport layer by introducing common interfaces shared by all
> protocols
> ------------------------------------------------------------------------------------
>
> Key: QPID-3342
> URL: https://issues.apache.org/jira/browse/QPID-3342
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
> Attachments:
> 0002-QPID-3342-rationalise-the-existing-0-10-transport-co.patch,
> 0003-QPID-3342-transition-TCP-based-Mina-transport-for-0-.patch
>
>
> Refactor the transport stack by introducing two new interfaces
> NetworkTransport and NetworkConnection. Remove dependencies between
> IoSender and IoReceiver.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
