[
https://issues.apache.org/jira/browse/QPID-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061519#comment-13061519
]
Rajith Attapattu commented on QPID-3342:
----------------------------------------
I briefly looked at some of changes on the client side and let me start with a
positive comment :)
It seems a lot of unused code has been deleted. This was long overdue and kudos
for doing so.
One thing I wasn't very happy about was the removal of TransportBuilder.java -
All though it wasn't perfect, this class at least abstracted out the building
of sender and receiver pipelines. Now that code is been put back directly into
the Connection class. Not exactly an improvement unless what I see so far is
interim code with more changes being planed.
This is where a review/discussion along with a write up could have helped. I
now see QPID-3345. It's quite possible that I am missing pieces of the final
puzzle. But then again these things should have been communicated upfront.
> Rationalise transport layer by introducing common interfaces shared by all
> protocols
> ------------------------------------------------------------------------------------
>
> Key: QPID-3342
> URL: https://issues.apache.org/jira/browse/QPID-3342
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
> Attachments:
> 0002-QPID-3342-rationalise-the-existing-0-10-transport-co.patch,
> 0003-QPID-3342-transition-TCP-based-Mina-transport-for-0-.patch
>
>
> Refactor the transport stack by introducing two new interfaces
> NetworkTransport and NetworkConnection. Remove dependencies between
> IoSender and IoReceiver.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
