[
https://issues.apache.org/jira/browse/QPID-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061562#comment-13061562
]
Rajith Attapattu commented on QPID-3342:
----------------------------------------
Robbie,
While it is true that Andrew proposal was covered with detailed JIRA's a design
doc and a fair amount of discussion, there was no indication that the changes
committed were infact from that branch. As you've mentioned it's a
reimplementation and therefore would have been nice if some heads up was given.
At the least an email to the dev list highlighting the scope of the impending
commit (and any future work being planned) and mentioning that this was an
extension of Andrew's work.
If these changes were infact from that branch, then they could have been
committed under Andrew's JIRA's which I believe is the right thing to do.
Instead those JIRA's were marked invalid and two new JIRA's were created this
morning and the changes were committed under them, giving the impression this
was a completely different thing.
I don't doubt your competence at all and as I have mentioned you do quite a
good job at reviews. But the fact remains that it's a substantial amount of
work and some advance notification about the impending commit would have not
only being courteous but also fair. I agree that minimal changes was done on
the client side and most of the changes were on the broker side. I also agree
that this is not the first instance that this has happened. But none of these
are excuses for the clear lack of communication here.
Regards,
Rajith
> Rationalise transport layer by introducing common interfaces shared by all
> protocols
> ------------------------------------------------------------------------------------
>
> Key: QPID-3342
> URL: https://issues.apache.org/jira/browse/QPID-3342
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client, Java Common
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
> Attachments:
> 0002-QPID-3342-rationalise-the-existing-0-10-transport-co.patch,
> 0003-QPID-3342-transition-TCP-based-Mina-transport-for-0-.patch
>
>
> Refactor the transport stack by introducing two new interfaces
> NetworkTransport and NetworkConnection. Remove dependencies between
> IoSender and IoReceiver.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
