> On June 9, 2015, 1:59 p.m., Flavio Percoco wrote: > > proton-c/src/platform.c, line 64 > > <https://reviews.apache.org/r/35252/diff/2/?file=981447#file981447line64> > > > > I'll move this to `uuid.c` as suggested by Alan in the previous review.
If we want to be _really_ pedantic, we'd add a new 'get pid' function to platform.c and then put the uuid code in uuid.c/h (it will use the new 'get pid()' for building the random seed). I don't think we want the uuid function to be part of the visible api, however. that uuid.h would not go in proton-c/include/proton. But honestly - meh. I'm fine with the current impl for now. - Kenneth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35252/#review87175 ----------------------------------------------------------- On June 9, 2015, 2:11 p.m., Flavio Percoco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35252/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 2:11 p.m.) > > > Review request for qpid, Alan Conway, Chug Rolke, Gordon Sim, and Rafael > Schloming. > > > Repository: qpid-proton-git > > > Description > ------- > > Instead of relying on libuuid for uuid generation, let proton-c have a > built-in uuid4 generator to do this job. > > > Diffs > ----- > > proton-c/CMakeLists.txt b534e86 > proton-c/bindings/python/setup.py 79168d2 > proton-c/src/messenger/messenger.c f226f7b > proton-c/src/platform.h 6962493 > proton-c/src/platform.c 8f8ac5f > > Diff: https://reviews.apache.org/r/35252/diff/ > > > Testing > ------- > > > Thanks, > > Flavio Percoco > >
