----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35252/#review87213 -----------------------------------------------------------
proton-c/src/platform.c <https://reviews.apache.org/r/35252/#comment139526> What version and type of uuid is being generated here - please put some comment and references here so that I can go to an rfc and check. proton-c/src/platform.c <https://reviews.apache.org/r/35252/#comment139529> My very limited knowledge of cryptographic code tells me that the rand() family chould **never** be used, as they aren't very good - where did you get this code from? Can we have someone who know something about cryptography check this out? proton-c/src/platform.c <https://reviews.apache.org/r/35252/#comment139527> Some mistake here surely. - Andrew Stitcher On June 9, 2015, 2:11 p.m., Flavio Percoco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35252/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 2:11 p.m.) > > > Review request for qpid, Alan Conway, Chug Rolke, Gordon Sim, and Rafael > Schloming. > > > Repository: qpid-proton-git > > > Description > ------- > > Instead of relying on libuuid for uuid generation, let proton-c have a > built-in uuid4 generator to do this job. > > > Diffs > ----- > > proton-c/CMakeLists.txt b534e86 > proton-c/bindings/python/setup.py 79168d2 > proton-c/src/messenger/messenger.c f226f7b > proton-c/src/platform.h 6962493 > proton-c/src/platform.c 8f8ac5f > > Diff: https://reviews.apache.org/r/35252/diff/ > > > Testing > ------- > > > Thanks, > > Flavio Percoco > >
