> On June 9, 2015, 4:03 p.m., Andrew Stitcher wrote: > > proton-c/src/platform.c, line 62 > > <https://reviews.apache.org/r/35252/diff/2/?file=981447#file981447line62> > > > > What version and type of uuid is being generated here - please put some > > comment and references here so that I can go to an rfc and check.
It's an uuid4, It's in the commit message. I had the RFC in the previous review but I accitentally removed it. I'll add a comment. > On June 9, 2015, 4:03 p.m., Andrew Stitcher wrote: > > proton-c/src/platform.c, line 77 > > <https://reviews.apache.org/r/35252/diff/2/?file=981447#file981447line77> > > > > My very limited knowledge of cryptographic code tells me that the > > rand() family chould **never** be used, as they aren't very good - where > > did you get this code from? > > > > Can we have someone who know something about cryptography check this > > out? You make a very good point about cryptography and we having this custom implementation. The reason I feel comfortable with this is because it's just being used to generate the messenger name but having it in the source code means that someone might use it in the future. This is exactly the reason why I think we shouldn't be using UUID's at all to generate the messenger name but just some random number. That said, considering this is an UUID4 - as also explicitly state by the function name itself - I think it doesn't matter much. The UUID4 is based on truly-random or pseudo-random numbers generation as stated in the RFC. http://tools.ietf.org/html/rfc4122#section-4.4 > On June 9, 2015, 4:03 p.m., Andrew Stitcher wrote: > > proton-c/src/platform.c, line 78 > > <https://reviews.apache.org/r/35252/diff/2/?file=981447#file981447line78> > > > > Some mistake here surely. wow, good catch :S - Flavio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35252/#review87213 ----------------------------------------------------------- On June 9, 2015, 2:11 p.m., Flavio Percoco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35252/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 2:11 p.m.) > > > Review request for qpid, Alan Conway, Chug Rolke, Gordon Sim, and Rafael > Schloming. > > > Repository: qpid-proton-git > > > Description > ------- > > Instead of relying on libuuid for uuid generation, let proton-c have a > built-in uuid4 generator to do this job. > > > Diffs > ----- > > proton-c/CMakeLists.txt b534e86 > proton-c/bindings/python/setup.py 79168d2 > proton-c/src/messenger/messenger.c f226f7b > proton-c/src/platform.h 6962493 > proton-c/src/platform.c 8f8ac5f > > Diff: https://reviews.apache.org/r/35252/diff/ > > > Testing > ------- > > > Thanks, > > Flavio Percoco > >
