[ 
https://issues.apache.org/jira/browse/PROTON-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969619#comment-16969619
 ] 

ASF GitHub Bot commented on PROTON-2115:
----------------------------------------

jdanekrh commented on pull request #205: PROTON-2115 Set only the soft process 
limit in fdlimit test
URL: https://github.com/apache/qpid-proton/pull/205
 
 
   Otherwise, when setting both the soft and hard limit it may fail with
   
       prlimit: failed to set the NOFILE resource limit: Operation not permitted
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Bitrot in qpid-proton/c/tests/fdlimit.py
> ----------------------------------------
>
>                 Key: PROTON-2115
>                 URL: https://issues.apache.org/jira/browse/PROTON-2115
>             Project: Qpid Proton
>          Issue Type: Test
>    Affects Versions: proton-c-0.29.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Major
>
> Originally, {{Proc}} was imported in scope, 
> https://github.com/apache/qpid-proton/commit/087b94faef6f0bc3fc2eac50ba0d2c2b03d82fbd#diff-9ad88150e74c307cdd1f621348dca9d6R20
> Nowadays, it isn't, current state of the file is this 
> https://github.com/apache/qpid-proton/blob/9778eda8e9387caa8a207fbb6fedfa09ac0e298a/c/tests/fdlimit.py#L41
>  
> {noformat}
> # Check if we can run prlimit to control resources
> try:
>     Proc(["prlimit"]).wait_exit()
> except:
>     print("Skipping test: prlimit not available")
>     sys.exit(0)
> {noformat}
> The broad except masks the error here, and also anything else in the rest of 
> the file (which is never executed).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to