[ 
https://issues.apache.org/jira/browse/PROTON-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984560#comment-16984560
 ] 

ASF subversion and git services commented on PROTON-2115:
---------------------------------------------------------

Commit 5a637e6ff90c5ca844a7500bf6e08435103f5843 in qpid-proton's branch 
refs/heads/master from Jiří Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=5a637e6 ]

PROTON-2115 fix typo in tests/py/test_unittest.py breaking fd-limit test (#220)



> Bitrot in qpid-proton/c/tests/fdlimit.py
> ----------------------------------------
>
>                 Key: PROTON-2115
>                 URL: https://issues.apache.org/jira/browse/PROTON-2115
>             Project: Qpid Proton
>          Issue Type: Test
>          Components: proton-c
>    Affects Versions: proton-c-0.29.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Major
>             Fix For: proton-c-0.30.0
>
>
> Originally, {{Proc}} was imported in scope, 
> https://github.com/apache/qpid-proton/commit/087b94faef6f0bc3fc2eac50ba0d2c2b03d82fbd#diff-9ad88150e74c307cdd1f621348dca9d6R20
> Nowadays, it isn't, current state of the file is this 
> https://github.com/apache/qpid-proton/blob/9778eda8e9387caa8a207fbb6fedfa09ac0e298a/c/tests/fdlimit.py#L41
>  
> {noformat}
> # Check if we can run prlimit to control resources
> try:
>     Proc(["prlimit"]).wait_exit()
> except:
>     print("Skipping test: prlimit not available")
>     sys.exit(0)
> {noformat}
> The broad except masks the error here, and also anything else in the rest of 
> the file (which is never executed).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to