[
https://issues.apache.org/jira/browse/PROTON-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973598#comment-16973598
]
Jiri Daněk commented on PROTON-2115:
------------------------------------
Test is not being run under valgrind in current master, and I've made sure that
it won't run under valgrind even after my change for PROTON-2135. The only
worrying thing about fdlimit test is the failure in Travis on PR
https://github.com/apache/qpid-proton/pull/202 for PROTON-2130,
https://travis-ci.org/apache/qpid-proton/builds/608636995. I think it is ok to
close, since master is green.
> Bitrot in qpid-proton/c/tests/fdlimit.py
> ----------------------------------------
>
> Key: PROTON-2115
> URL: https://issues.apache.org/jira/browse/PROTON-2115
> Project: Qpid Proton
> Issue Type: Test
> Affects Versions: proton-c-0.29.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
>
> Originally, {{Proc}} was imported in scope,
> https://github.com/apache/qpid-proton/commit/087b94faef6f0bc3fc2eac50ba0d2c2b03d82fbd#diff-9ad88150e74c307cdd1f621348dca9d6R20
> Nowadays, it isn't, current state of the file is this
> https://github.com/apache/qpid-proton/blob/9778eda8e9387caa8a207fbb6fedfa09ac0e298a/c/tests/fdlimit.py#L41
>
> {noformat}
> # Check if we can run prlimit to control resources
> try:
> Proc(["prlimit"]).wait_exit()
> except:
> print("Skipping test: prlimit not available")
> sys.exit(0)
> {noformat}
> The broad except masks the error here, and also anything else in the rest of
> the file (which is never executed).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
