[ 
https://issues.apache.org/jira/browse/PROTON-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970821#comment-16970821
 ] 

Jiri Daněk commented on PROTON-2115:
------------------------------------

There is one outstanding problem with this, detected by Travis. When running 
with RUNTIME_CHECK=memcheck (which is the default when valgrind is present), 
the test may fail on Valgrind error

{noformat}
7: ======================================================================
7: ERROR: test_fd_limit_broker (__main__.FdLimitTest)
7: Check behaviour when running out of file descriptors on accept
7: ----------------------------------------------------------------------
7: Traceback (most recent call last):
7:   File "/home/travis/build/jdanekrh/qpid-proton/c/tests/fdlimit.py", line 
83, in test_fd_limit_broker
7:     self.assertEqual(sender.wait(), 0)
7:   File 
"/home/travis/build/jdanekrh/qpid-proton/tests/py/test_subprocess.py", line 
110, in __exit__
7:     self.on_exit()
7:   File 
"/home/travis/build/jdanekrh/qpid-proton/tests/py/test_subprocess.py", line 69, 
in check_wait
7:     raise TestProcessError(self, "check_wait")
7: TestProcessError: ['/usr/bin/valgrind', '--tool=memcheck', 
'--leak-check=full', '--error-exitcode=42', '--quiet', 
'--suppressions=/home/travis/build/jdanekrh/qpid-proton/tests/valgrind.supp', 
'send', '', '35921', 'x'] pid=11377 exit=127: check_wait
7: ________________________________ stderr(11377) 
________________________________
7: /usr/bin/valgrind.bin: error while loading shared libraries: libc.so.6: 
cannot create shared object descriptor: Cannot allocate memory
7: ________________________________ stderr(11377) 
________________________________
{noformat}

https://travis-ci.org/jdanekrh/qpid-proton/jobs/609620365

Only solution I can come up with would be to not run valgrind.

> Bitrot in qpid-proton/c/tests/fdlimit.py
> ----------------------------------------
>
>                 Key: PROTON-2115
>                 URL: https://issues.apache.org/jira/browse/PROTON-2115
>             Project: Qpid Proton
>          Issue Type: Test
>    Affects Versions: proton-c-0.29.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Major
>
> Originally, {{Proc}} was imported in scope, 
> https://github.com/apache/qpid-proton/commit/087b94faef6f0bc3fc2eac50ba0d2c2b03d82fbd#diff-9ad88150e74c307cdd1f621348dca9d6R20
> Nowadays, it isn't, current state of the file is this 
> https://github.com/apache/qpid-proton/blob/9778eda8e9387caa8a207fbb6fedfa09ac0e298a/c/tests/fdlimit.py#L41
>  
> {noformat}
> # Check if we can run prlimit to control resources
> try:
>     Proc(["prlimit"]).wait_exit()
> except:
>     print("Skipping test: prlimit not available")
>     sys.exit(0)
> {noformat}
> The broad except masks the error here, and also anything else in the rest of 
> the file (which is never executed).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to