alex-rufous commented on a change in pull request #77:
URL: https://github.com/apache/qpid-broker-j/pull/77#discussion_r563353756
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -199,7 +200,7 @@ public void testOpenDatabaseReusesCachedHandle() throws
Exception
{
DatabaseConfig createIfAbsentDbConfig =
DatabaseConfig.DEFAULT.setAllowCreate(true);
- EnvironmentFacade ef = createMaster();
+ EnvironmentFacade ef = createMaster(false);
Review comment:
As per above please use overloaded method `createMaster()`
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -284,10 +285,27 @@ public void testSetMessageStoreDurability() throws
Exception
assertFalse("Coalescing sync committer is still running",
master.isCoalescingSync());
}
+ @Test
+ public void testSetMessageStoreDurabilityWithDisabledCoalescingSync()
throws Exception
+ {
+ ReplicatedEnvironmentFacade master = createMaster(true);
+ assertEquals("Unexpected message store durability",
+ new Durability(Durability.SyncPolicy.SYNC,
Durability.SyncPolicy.NO_SYNC, Durability.ReplicaAckPolicy.SIMPLE_MAJORITY),
+ master.getRealMessageStoreDurability());
+ assertEquals("Unexpected durability", TEST_DURABILITY,
master.getMessageStoreDurability());
+ assertFalse("Unexpected coalescing sync", master.isCoalescingSync());
+
+ master.setMessageStoreDurability(Durability.SyncPolicy.SYNC,
Durability.SyncPolicy.WRITE_NO_SYNC, Durability.ReplicaAckPolicy.ALL);
+ assertEquals("Unexpected message store durability",
+ new Durability(Durability.SyncPolicy.SYNC,
Durability.SyncPolicy.WRITE_NO_SYNC, Durability.ReplicaAckPolicy.ALL),
+ master.getRealMessageStoreDurability());
+ assertFalse("Coalescing sync committer is still running",
master.isCoalescingSync());
+ }
+
@Test
public void testGetNodeState() throws Exception
{
- assertEquals("Unexpected state", State.MASTER.name(),
createMaster().getNodeState());
+ assertEquals("Unexpected state", State.MASTER.name(),
createMaster(false).getNodeState());
Review comment:
As per comments above please use overloaded method `createMaster()`
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -791,7 +809,7 @@ public void stateChange(StateChangeEvent event) throws
RuntimeException
}
};
ReplicatedEnvironmentFacade thirdNode = addNode(TEST_NODE_NAME + "_2",
node2NodeHostPort, TEST_DESIGNATED_PRIMARY,
-
testStateChangeListener, new NoopReplicationGroupListener());
+
testStateChangeListener, new NoopReplicationGroupListener(),false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -911,7 +929,7 @@ public void testSetPermittedNodes() throws Exception
@Test
public void testPermittedNodeIsAllowedToConnect() throws Exception
{
- ReplicatedEnvironmentFacade firstNode = createMaster();
+ ReplicatedEnvironmentFacade firstNode = createMaster(false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -256,21 +257,21 @@ public void testLastKnownReplicationTransactionId()
throws Exception
@Test
public void testGetNodeHostPort() throws Exception
{
- assertEquals("Unexpected node host port", TEST_NODE_HOST_PORT,
createMaster().getHostPort());
+ assertEquals("Unexpected node host port", TEST_NODE_HOST_PORT,
createMaster(false).getHostPort());
Review comment:
As per comments above please use overloaded method `createMaster()`
##########
File path:
bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacade.java
##########
@@ -135,6 +137,11 @@
*/
private final int _executorShutdownTimeout;
+ /**
Review comment:
A property name is self-explanatory. The comment is redundant and can be
deleted
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -186,7 +187,7 @@ public void tearDown() throws Exception
@Test
public void testClose() throws Exception
{
- ReplicatedEnvironmentFacade ef = createMaster();
+ ReplicatedEnvironmentFacade ef = createMaster(false);
Review comment:
Please add an overloaded method `createMaster()` where
`disableCoalescing` can be set to fase
private ReplicatedEnvironmentFacade createMaster() throws Exception
{
return createMaster(false);
}
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -234,19 +235,19 @@ public void testOpenDatabaseWhenFacadeIsNotOpened()
throws Exception
@Test
public void testGetGroupName() throws Exception
{
- assertEquals("Unexpected group name", TEST_GROUP_NAME,
createMaster().getGroupName());
+ assertEquals("Unexpected group name", TEST_GROUP_NAME,
createMaster(false).getGroupName());
Review comment:
As per comments above please use overloaded method `createMaster()`
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -284,10 +285,27 @@ public void testSetMessageStoreDurability() throws
Exception
assertFalse("Coalescing sync committer is still running",
master.isCoalescingSync());
}
+ @Test
+ public void testSetMessageStoreDurabilityWithDisabledCoalescingSync()
throws Exception
+ {
+ ReplicatedEnvironmentFacade master = createMaster(true);
+ assertEquals("Unexpected message store durability",
+ new Durability(Durability.SyncPolicy.SYNC,
Durability.SyncPolicy.NO_SYNC, Durability.ReplicaAckPolicy.SIMPLE_MAJORITY),
+ master.getRealMessageStoreDurability());
+ assertEquals("Unexpected durability", TEST_DURABILITY,
master.getMessageStoreDurability());
+ assertFalse("Unexpected coalescing sync", master.isCoalescingSync());
+
+ master.setMessageStoreDurability(Durability.SyncPolicy.SYNC,
Durability.SyncPolicy.WRITE_NO_SYNC, Durability.ReplicaAckPolicy.ALL);
Review comment:
I would rather change local durability to NO_SYNC as the implemented
change is for a local node
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -284,10 +285,27 @@ public void testSetMessageStoreDurability() throws
Exception
assertFalse("Coalescing sync committer is still running",
master.isCoalescingSync());
}
+ @Test
+ public void testSetMessageStoreDurabilityWithDisabledCoalescingSync()
throws Exception
+ {
+ ReplicatedEnvironmentFacade master = createMaster(true);
+ assertEquals("Unexpected message store durability",
+ new Durability(Durability.SyncPolicy.SYNC,
Durability.SyncPolicy.NO_SYNC, Durability.ReplicaAckPolicy.SIMPLE_MAJORITY),
+ master.getRealMessageStoreDurability());
+ assertEquals("Unexpected durability", TEST_DURABILITY,
master.getMessageStoreDurability());
Review comment:
this assert is redundant. It duplicates the assert above
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -296,7 +314,7 @@ public void testPriority() throws Exception
final TestStateChangeListener masterListener = new
TestStateChangeListener();
final ReplicationGroupListener masterGroupListener = new
NoopReplicationGroupListener();
- ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
TEST_DESIGNATED_PRIMARY);
+ ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
TEST_DESIGNATED_PRIMARY, false);
Review comment:
This change can be reverted and overloaded method
createReplicatedEnvironmentConfiguration can be introduced to set
disableCommiter to false
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -234,19 +235,19 @@ public void testOpenDatabaseWhenFacadeIsNotOpened()
throws Exception
@Test
public void testGetGroupName() throws Exception
{
- assertEquals("Unexpected group name", TEST_GROUP_NAME,
createMaster().getGroupName());
+ assertEquals("Unexpected group name", TEST_GROUP_NAME,
createMaster(false).getGroupName());
}
@Test
public void testGetNodeName() throws Exception
{
- assertEquals("Unexpected group name", TEST_NODE_NAME,
createMaster().getNodeName());
+ assertEquals("Unexpected group name", TEST_NODE_NAME,
createMaster(false).getNodeName());
Review comment:
As per comments above please use overloaded method `createMaster()`
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -234,19 +235,19 @@ public void testOpenDatabaseWhenFacadeIsNotOpened()
throws Exception
@Test
public void testGetGroupName() throws Exception
{
- assertEquals("Unexpected group name", TEST_GROUP_NAME,
createMaster().getGroupName());
+ assertEquals("Unexpected group name", TEST_GROUP_NAME,
createMaster(false).getGroupName());
}
@Test
public void testGetNodeName() throws Exception
{
- assertEquals("Unexpected group name", TEST_NODE_NAME,
createMaster().getNodeName());
+ assertEquals("Unexpected group name", TEST_NODE_NAME,
createMaster(false).getNodeName());
}
@Test
public void testLastKnownReplicationTransactionId() throws Exception
{
- ReplicatedEnvironmentFacade master = createMaster();
+ ReplicatedEnvironmentFacade master = createMaster(false);
Review comment:
As per comments above please use overloaded method `createMaster()`
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -361,7 +379,7 @@ public void testElectableGroupSizeOverride() throws
Exception
@Test
public void
testReplicationGroupListenerHearsAboutExistingRemoteReplicationNodes() throws
Exception
{
- ReplicatedEnvironmentFacade master = createMaster();
+ ReplicatedEnvironmentFacade master = createMaster(false);
Review comment:
This change can be reverted and overloaded method createMaster can be
introduced to set disableCommiter to false
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -256,21 +257,21 @@ public void testLastKnownReplicationTransactionId()
throws Exception
@Test
public void testGetNodeHostPort() throws Exception
{
- assertEquals("Unexpected node host port", TEST_NODE_HOST_PORT,
createMaster().getHostPort());
+ assertEquals("Unexpected node host port", TEST_NODE_HOST_PORT,
createMaster(false).getHostPort());
}
@Test
public void testGetHelperHostPort() throws Exception
{
assertEquals("Unexpected node helper host port",
TEST_NODE_HELPER_HOST_PORT,
- createMaster().getHelperHostPort());
+ createMaster(false).getHelperHostPort());
}
@Test
public void testSetMessageStoreDurability() throws Exception
{
- ReplicatedEnvironmentFacade master = createMaster();
+ ReplicatedEnvironmentFacade master = createMaster(false);
Review comment:
As per comments above please use overloaded method `createMaster()`
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -403,7 +421,7 @@ public void onReplicationNodeAddedToGroup(ReplicationNode
node)
};
TestStateChangeListener stateChangeListener = new
TestStateChangeListener();
- ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
addNode(stateChangeListener, listener);
+ ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
addNode(stateChangeListener, listener,false);
Review comment:
This change can be reverted and overloaded method addNode can be
introduced to set disableCommiter to false
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -338,7 +356,7 @@ public void testElectableGroupSizeOverride() throws
Exception
final TestStateChangeListener masterListener = new
TestStateChangeListener();
final ReplicationGroupListener masterGroupListener = new
NoopReplicationGroupListener();
- ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
false);
+ ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
false,false);
Review comment:
This change can be reverted and overloaded method
createReplicatedEnvironmentConfiguration can be introduced to set
disableCommiter to false
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -567,7 +585,7 @@ public void testRemoveNodeFromGroupTwice() throws Exception
TEST_NODE_HOST_PORT,
true,
stateChangeListener,
- new
NoopReplicationGroupListener());
+ new
NoopReplicationGroupListener(),false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -317,7 +335,7 @@ public void testDesignatedPrimary() throws Exception
final TestStateChangeListener masterListener = new
TestStateChangeListener();
final ReplicationGroupListener masterGroupListener = new
NoopReplicationGroupListener();
- ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
TEST_DESIGNATED_PRIMARY);
+ ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
TEST_DESIGNATED_PRIMARY,false);
Review comment:
This change can be reverted and overloaded method
createReplicatedEnvironmentConfiguration can be introduced to set
disableCommiter to false
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -1072,7 +1090,7 @@ public Transaction call() throws Exception
@Test
public void
testReplicaWriteExceptionIsConvertedIntoConnectionScopedRuntimeException()
throws Exception
{
- ReplicatedEnvironmentFacade master = createMaster();
+ ReplicatedEnvironmentFacade master = createMaster(false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -455,7 +473,7 @@ public void
onReplicationNodeRemovedFromGroup(ReplicationNode node)
};
TestStateChangeListener stateChangeListener = new
TestStateChangeListener();
- ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
addNode(stateChangeListener, listener);
+ ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
addNode(stateChangeListener, listener,false);
Review comment:
This change can be reverted and overloaded method addNode can be
introduced to set disableCommiter to false
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -823,7 +841,7 @@ public void stateChange(StateChangeEvent event) throws
RuntimeException
}
}
};
- ReplicatedEnvironmentFacade firstNode = addNode(stateChangeListener,
new NoopReplicationGroupListener());
+ ReplicatedEnvironmentFacade firstNode = addNode(stateChangeListener,
new NoopReplicationGroupListener(),false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -706,7 +724,7 @@ else if (stateChangeEvent.getState() == State.UNKNOWN)
};
// make sure that node is re-elected as MASTER on second start-up
- ReplicatedEnvironmentConfiguration config =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
TEST_DESIGNATED_PRIMARY);
+ ReplicatedEnvironmentConfiguration config =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
TEST_DESIGNATED_PRIMARY,false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -761,7 +779,7 @@ public void stateChange(StateChangeEvent event) throws
RuntimeException
}
}
};
- ReplicatedEnvironmentFacade firstNode = addNode(stateChangeListener,
new NoopReplicationGroupListener());
+ ReplicatedEnvironmentFacade firstNode = addNode(stateChangeListener,
new NoopReplicationGroupListener(),false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -630,7 +648,7 @@ public void onNodeState(ReplicationNode node, NodeState
nodeState)
};
TestStateChangeListener stateChangeListener = new
TestStateChangeListener();
- final ReplicatedEnvironmentFacade masterEnvironment =
addNode(stateChangeListener, listener);
+ final ReplicatedEnvironmentFacade masterEnvironment =
addNode(stateChangeListener, listener,false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -661,7 +679,7 @@ public void onNodeState(ReplicationNode node, NodeState
nodeState)
@Test
public void testCloseStateTransitions() throws Exception
{
- ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
createMaster();
+ ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
createMaster(false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -217,7 +218,7 @@ public void testOpenDatabaseWhenFacadeIsNotOpened() throws
Exception
{
DatabaseConfig createIfAbsentDbConfig =
DatabaseConfig.DEFAULT.setAllowCreate(true);
- EnvironmentFacade ef = createMaster();
+ EnvironmentFacade ef = createMaster(false);
Review comment:
As per above please use overloaded method `createMaster()`
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -540,7 +558,7 @@ public void onNodeState(ReplicationNode node, NodeState
nodeState)
public void testRemoveNodeFromGroup() throws Exception
{
TestStateChangeListener stateChangeListener = new
TestStateChangeListener();
- ReplicatedEnvironmentFacade environmentFacade =
addNode(TEST_NODE_NAME, TEST_NODE_HOST_PORT, true, stateChangeListener, new
NoopReplicationGroupListener());
+ ReplicatedEnvironmentFacade environmentFacade =
addNode(TEST_NODE_NAME, TEST_NODE_HOST_PORT, true, stateChangeListener, new
NoopReplicationGroupListener(),false);
Review comment:
This change can be reverted and overloaded method addNode can be
introduced to set disableCommiter to false
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -891,7 +909,7 @@ public void testBeginTransaction() throws Exception
@Test
public void testSetPermittedNodes() throws Exception
{
- ReplicatedEnvironmentFacade firstNode = createMaster();
+ ReplicatedEnvironmentFacade firstNode = createMaster(false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -967,7 +985,7 @@ public void testNodeRolledback() throws Exception
createConfig.setTransactional(true);
TestStateChangeListener masterListener = new TestStateChangeListener();
- ReplicatedEnvironmentFacade node1 = addNode(TEST_NODE_NAME,
TEST_NODE_HOST_PORT, true, masterListener, new NoopReplicationGroupListener());
+ ReplicatedEnvironmentFacade node1 = addNode(TEST_NODE_NAME,
TEST_NODE_HOST_PORT, true, masterListener, new
NoopReplicationGroupListener(),false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -868,7 +886,7 @@ public void stateChange(StateChangeEvent event) throws
RuntimeException
@Test
public void testBeginTransaction() throws Exception
{
- ReplicatedEnvironmentFacade facade = createMaster();
+ ReplicatedEnvironmentFacade facade = createMaster(false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -1016,7 +1034,7 @@ public void onNodeRolledback()
LOGGER.debug("onNodeRolledback in " + TEST_NODE_NAME);
_replicaRolledback.countDown();
}
- });
+ },false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -1160,7 +1178,7 @@ public void onNoMajority()
}
};
- ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
false);
+ ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
false,false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -921,7 +939,7 @@ public void testPermittedNodeIsAllowedToConnect() throws
Exception
permittedNodes.add(node1NodeHostPort);
firstNode.setPermittedNodes(permittedNodes);
- ReplicatedEnvironmentConfiguration configuration =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME + "_1",
node1NodeHostPort, false);
+ ReplicatedEnvironmentConfiguration configuration =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME + "_1",
node1NodeHostPort, false,false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -993,7 +1011,7 @@ public void testNodeRolledback() throws Exception
LOGGER.debug("RESTARTING " + replicaName);
// Restart the node2, making it primary so it becomes master
TestStateChangeListener node2StateChangeListener = new
TestStateChangeListener();
- node2 = addNode(replicaName, replicaNodeHostPort, true,
node2StateChangeListener, new NoopReplicationGroupListener());
+ node2 = addNode(replicaName, replicaNodeHostPort, true,
node2StateChangeListener, new NoopReplicationGroupListener(),false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -1034,7 +1052,7 @@ public void onNodeRolledback()
@Test
public void testReplicaTransactionBeginsImmediately() throws Exception
{
- ReplicatedEnvironmentFacade master = createMaster();
+ ReplicatedEnvironmentFacade master = createMaster(false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -945,7 +963,7 @@ public boolean onIntruderNode(ReplicationNode node)
return true;
}
};
- ReplicatedEnvironmentFacade firstNode = createMaster(listener);
+ ReplicatedEnvironmentFacade firstNode = createMaster(listener,false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -514,7 +532,7 @@ public void onNodeState(ReplicationNode node, NodeState
nodeState)
};
TestStateChangeListener stateChangeListener = new
TestStateChangeListener();
- ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
addNode(stateChangeListener, listener);
+ ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
addNode(stateChangeListener, listener,false);
Review comment:
This change can be reverted and overloaded method addNode can be
introduced to set disableCommiter to false
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -1111,7 +1129,7 @@ public void onNoMajority()
}
};
- ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
false);
+ ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
false,false);
Review comment:
please revert
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -854,7 +872,7 @@ public void stateChange(StateChangeEvent event) throws
RuntimeException
};
String thirdNodeName = TEST_NODE_NAME + "_2";
ReplicatedEnvironmentFacade thirdNode = addNode(thirdNodeName,
node2NodeHostPort, TEST_DESIGNATED_PRIMARY,
-
testStateChangeListener, new NoopReplicationGroupListener());
+
testStateChangeListener, new NoopReplicationGroupListener(),false);
Review comment:
please revert
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
