Dedeepya-T commented on a change in pull request #77:
URL: https://github.com/apache/qpid-broker-j/pull/77#discussion_r563538143
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -296,7 +314,7 @@ public void testPriority() throws Exception
final TestStateChangeListener masterListener = new
TestStateChangeListener();
final ReplicationGroupListener masterGroupListener = new
NoopReplicationGroupListener();
- ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
TEST_DESIGNATED_PRIMARY);
+ ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
TEST_DESIGNATED_PRIMARY, false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -317,7 +335,7 @@ public void testDesignatedPrimary() throws Exception
final TestStateChangeListener masterListener = new
TestStateChangeListener();
final ReplicationGroupListener masterGroupListener = new
NoopReplicationGroupListener();
- ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
TEST_DESIGNATED_PRIMARY);
+ ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
TEST_DESIGNATED_PRIMARY,false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -338,7 +356,7 @@ public void testElectableGroupSizeOverride() throws
Exception
final TestStateChangeListener masterListener = new
TestStateChangeListener();
final ReplicationGroupListener masterGroupListener = new
NoopReplicationGroupListener();
- ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
false);
+ ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
false,false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -361,7 +379,7 @@ public void testElectableGroupSizeOverride() throws
Exception
@Test
public void
testReplicationGroupListenerHearsAboutExistingRemoteReplicationNodes() throws
Exception
{
- ReplicatedEnvironmentFacade master = createMaster();
+ ReplicatedEnvironmentFacade master = createMaster(false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -403,7 +421,7 @@ public void onReplicationNodeAddedToGroup(ReplicationNode
node)
};
TestStateChangeListener stateChangeListener = new
TestStateChangeListener();
- ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
addNode(stateChangeListener, listener);
+ ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
addNode(stateChangeListener, listener,false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -455,7 +473,7 @@ public void
onReplicationNodeRemovedFromGroup(ReplicationNode node)
};
TestStateChangeListener stateChangeListener = new
TestStateChangeListener();
- ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
addNode(stateChangeListener, listener);
+ ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
addNode(stateChangeListener, listener,false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -514,7 +532,7 @@ public void onNodeState(ReplicationNode node, NodeState
nodeState)
};
TestStateChangeListener stateChangeListener = new
TestStateChangeListener();
- ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
addNode(stateChangeListener, listener);
+ ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
addNode(stateChangeListener, listener,false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -540,7 +558,7 @@ public void onNodeState(ReplicationNode node, NodeState
nodeState)
public void testRemoveNodeFromGroup() throws Exception
{
TestStateChangeListener stateChangeListener = new
TestStateChangeListener();
- ReplicatedEnvironmentFacade environmentFacade =
addNode(TEST_NODE_NAME, TEST_NODE_HOST_PORT, true, stateChangeListener, new
NoopReplicationGroupListener());
+ ReplicatedEnvironmentFacade environmentFacade =
addNode(TEST_NODE_NAME, TEST_NODE_HOST_PORT, true, stateChangeListener, new
NoopReplicationGroupListener(),false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -567,7 +585,7 @@ public void testRemoveNodeFromGroupTwice() throws Exception
TEST_NODE_HOST_PORT,
true,
stateChangeListener,
- new
NoopReplicationGroupListener());
+ new
NoopReplicationGroupListener(),false);
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
