Dedeepya-T commented on a change in pull request #77:
URL: https://github.com/apache/qpid-broker-j/pull/77#discussion_r563539005
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -630,7 +648,7 @@ public void onNodeState(ReplicationNode node, NodeState
nodeState)
};
TestStateChangeListener stateChangeListener = new
TestStateChangeListener();
- final ReplicatedEnvironmentFacade masterEnvironment =
addNode(stateChangeListener, listener);
+ final ReplicatedEnvironmentFacade masterEnvironment =
addNode(stateChangeListener, listener,false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -661,7 +679,7 @@ public void onNodeState(ReplicationNode node, NodeState
nodeState)
@Test
public void testCloseStateTransitions() throws Exception
{
- ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
createMaster();
+ ReplicatedEnvironmentFacade replicatedEnvironmentFacade =
createMaster(false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -706,7 +724,7 @@ else if (stateChangeEvent.getState() == State.UNKNOWN)
};
// make sure that node is re-elected as MASTER on second start-up
- ReplicatedEnvironmentConfiguration config =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
TEST_DESIGNATED_PRIMARY);
+ ReplicatedEnvironmentConfiguration config =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
TEST_DESIGNATED_PRIMARY,false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -761,7 +779,7 @@ public void stateChange(StateChangeEvent event) throws
RuntimeException
}
}
};
- ReplicatedEnvironmentFacade firstNode = addNode(stateChangeListener,
new NoopReplicationGroupListener());
+ ReplicatedEnvironmentFacade firstNode = addNode(stateChangeListener,
new NoopReplicationGroupListener(),false);
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]