Dedeepya-T commented on a change in pull request #77:
URL: https://github.com/apache/qpid-broker-j/pull/77#discussion_r563539636
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -1160,7 +1178,7 @@ public void onNoMajority()
}
};
- ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
false);
+ ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
false,false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -1111,7 +1129,7 @@ public void onNoMajority()
}
};
- ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
false);
+ ReplicatedEnvironmentConfiguration masterConfig =
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME, TEST_NODE_HOST_PORT,
false,false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -1072,7 +1090,7 @@ public Transaction call() throws Exception
@Test
public void
testReplicaWriteExceptionIsConvertedIntoConnectionScopedRuntimeException()
throws Exception
{
- ReplicatedEnvironmentFacade master = createMaster();
+ ReplicatedEnvironmentFacade master = createMaster(false);
Review comment:
Done!
##########
File path:
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -1034,7 +1052,7 @@ public void onNodeRolledback()
@Test
public void testReplicaTransactionBeginsImmediately() throws Exception
{
- ReplicatedEnvironmentFacade master = createMaster();
+ ReplicatedEnvironmentFacade master = createMaster(false);
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
