jiridanek commented on a change in pull request #1048: URL: https://github.com/apache/qpid-dispatch/pull/1048#discussion_r581392560
########## File path: tests/lsan.supp ########## @@ -23,15 +44,56 @@ leak:_ctypes_alloc_format_string leak:__strdup #### -#### Miscellaneous 3rd party libraries, test code, etc: +#### Miscellaneous 3rd party libraries: #### -leak:*libpython* -leak:*libwebsockets* -leak:*python2* +### Python -# We should be able to uncomment these once all known dispatch leaks have been fixed -leak:*libqpid-proton* +# these Python leaks happen even after simple Py_Initialize(); Py_Finalize(); +# https://bugs.python.org/issue1635741 +leak:^_PyObject_Realloc +leak:^PyObject_Malloc$ +leak:^PyThread_allocate_lock$ -# Ignore test code -leak:run_unit_tests.c +# the PyMalloc mechanism is incompatible with Valgrind, it must be disabled or reported "leaks" must be suppressed Review comment: Why? The way it is now (in the PR), the `lsan.supp` (or `lsan.supp.in` if I make that change) is a valid and usable LSan suppression file by itself, without any preprocessing. If I to do what you suggest, this will no longer be the case: (it will either contain CMake variable and won't be valid because of it, or it will not contain the individual Python function suppressions and will be incomplete). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
